added ssl_endpoint_identification_algorithm config option #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
reviewed
Dec 18, 2018
| @@ -140,6 +140,8 @@ class LogStash::Outputs::Kafka < LogStash::Outputs::Base | |||
| config :ssl_keystore_password, :validate => :password | |||
| # The password of the private key in the key store file. | |||
| config :ssl_key_password, :validate => :password | |||
| # Algorithm to use when verifying host. Set to "" to disable | |||
| config :ssl_endpoint_identification_algorithm, :validate => :string | |||
There was a problem hiding this comment.
Can you set the value explicitly to 'https' to ensure that the behavior remains the same in the (probably somewhat unlikely) event that the Kafka client changes defaults again
|
@JackDavidson I've included this in a follow-on commit that fixes an issue which was causing this not to work. Thanks for the contribution! |
|
@robbavey No problem :) It looks like the change was merged, so should I close this now? |
|
Changes merged along another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ssl_endpoint_identification_algorithm config option
matching pull request for output here:
logstash-plugins/logstash-input-kafka#301